-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(kit): InputNumber
should handle initial ngModel
phantom null
value
#10168
Conversation
Pull request was closed ✔️All saved screenshots (for current PR) were deleted 🗑️ |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10168 +/- ##
=======================================
Coverage 65.84% 65.84%
=======================================
Files 1233 1233
Lines 16092 16092
Branches 2331 2344 +13
=======================================
Hits 10595 10595
+ Misses 5269 5198 -71
- Partials 228 299 +71
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Visit the preview URL for this PR (updated for commit 2113fc4): https://taiga-previews-demo--pr10168-input-number-ngmodel-init-22xv8i19.web.app (expires Wed, 15 Jan 2025 13:21:28 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 73dddc3c665194f3e11f18c16aeb71af4c289c37 |
BundleMonUnchanged files (5)
Total files change -1B 0% Unchanged groups (1)
Final result: ✅ View report in BundleMon website ➡️ |
Playwright test results 2042 passed Details Open report ↗︎ Flaky testschromium › tests/kit/dropdown-hover/dropdown-hover.pw.spec.ts › DropdownHover › Examples › With DropdownMobile › Closes dropdown on click on overlay Skipped testswebkit › tests/addon-commerce/input-card-group.pw.spec.ts › InputCardGroup › Examples › input card grouped with validation |
Relates:
taiga-ui/projects/cdk/classes/control.ts
Lines 122 to 126 in 768f1ff
See: #10166 (comment)